Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove faulty adapter skip check in InvertibleAdaptersMixin #634

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove faulty adapter skip check in InvertibleAdaptersMixin #634

merged 1 commit into from
Jan 9, 2024

Conversation

calpt
Copy link
Member

@calpt calpt commented Jan 8, 2024

Fixes #633.

@calpt calpt marked this pull request as ready for review January 8, 2024 20:17
TimoImhof
TimoImhof approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@calpt calpt merged commit bca1ead into adapter-hub:main Jan 9, 2024
5 checks passed
@calpt calpt deleted the fix/invertible_mixin_skip branch January 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof TimoImhof approved these changes

@lenglaender lenglaender Awaiting requested review from lenglaender

@hSterz hSterz Awaiting requested review from hSterz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'RobertaModel' object has no attribute 'layer_idx'
2 participants
@calpt @TimoImhof